Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 9 French banks #224

Closed
wants to merge 2 commits into from
Closed

Add 9 French banks #224

wants to merge 2 commits into from

Conversation

aktiur
Copy link
Contributor

@aktiur aktiur commented Oct 3, 2024

I used to maintain a list of French banks before finding this package, and there were 9 I've seen in the wild that weren't in this project.

I'm not sure how the "primary" parameter should be set, please tell me if I've made a mistake.

@Natim
Copy link
Contributor

Natim commented Oct 3, 2024

What about those one? Should we add them as well?

Banque Marze 
Devengo
Banque des Territoires 
Crédit Municipal de Roubaix 
Crédit Municipal de Lyon 
Crédit Municipal de Boulogne sur Mer 
Crédit Municipal de Toulon 
Crédit Municipal de Nîmes 
Crédit Municipal de Nantes 
Louvre Banque Privée (ex BPE Banque Privée) 
Oney - Banque Accord 
Crédit Maritime Grand Ouest 
Crédit Maritime Atlantique 
Crédit Maritime Littoral du Sud-Ouest 
PayPal 
Rothschild Martin Maurel 
Yomoni 
Oney Banque 
American Express 
Finom 

@aktiur
Copy link
Contributor Author

aktiur commented Oct 3, 2024

What about those one? Should we add them as well?

Banque Marze 
Devengo
Banque des Territoires 
Crédit Municipal de Roubaix 
Crédit Municipal de Lyon 
Crédit Municipal de Boulogne sur Mer 
Crédit Municipal de Toulon 
Crédit Municipal de Nîmes 
Crédit Municipal de Nantes 
Louvre Banque Privée (ex BPE Banque Privée) 
Oney - Banque Accord 
Crédit Maritime Grand Ouest 
Crédit Maritime Atlantique 
Crédit Maritime Littoral du Sud-Ouest 
PayPal 
Rothschild Martin Maurel 
Yomoni 
Oney Banque 
American Express 
Finom 

Where did you find that list? I never found a complete list of french banks with both CIB and BIC.

@mdomke
Copy link
Owner

mdomke commented Oct 11, 2024

@aktiur Thanks for the added banks! The bank_code has to be a string even though it is numeric. That's the reason why the tests are failing.

@Natim Natim mentioned this pull request Oct 18, 2024
@mdomke
Copy link
Owner

mdomke commented Nov 11, 2024

@aktiur I'm closing this merge-request, since @Natim took the liberty to expand on it in #229, which just got merged. Thanks for your support!

@mdomke mdomke closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants