Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump ws from 7.4.0 to 7.5.0 #474

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 28, 2021

Bumps ws from 7.4.0 to 7.5.0.

Release notes

Sourced from ws's releases.

7.5.0

Features

  • Some errors now have a code property describing the specific type of error that has occurred (#1901).

Bug fixes

  • A close frame is now sent to the remote peer if an error (such as a data framing error) occurs (8806aa9a).
  • The close code is now always 1006 if no close frame is received, even if the connection is closed due to an error (8806aa9a).

7.4.6

Bug fixes

  • Fixed a ReDoS vulnerability (00c425ec).

A specially crafted value of the Sec-Websocket-Protocol header could be used to significantly slow down a ws server.

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();
value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);
}

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

7.4.5

Bug fixes

  • UTF-8 validation is now done even if utf-8-validate is not installed (23ba6b29).
  • Fixed an edge case where websocket.close() and websocket.terminate() did not close the connection (67e25ff5).

7.4.4

... (truncated)

Commits
  • e3f0c17 [dist] 7.5.0
  • 1d3f4cb [doc] Fix anchor tags for error codes
  • 6eea0d4 [doc] Fix typo
  • bb5d44b [doc] Sort error codes alphabetically
  • c6e3080 [minor] Attach error codes to all receiver errors (#1901)
  • 074e6a8 [fix] Don't call ws.terminate() unconditionally in duplex._destroy()
  • 8806aa9 [fix] Close the connection cleanly when an error occurs
  • 05b8ccd [doc] Fix broken link (#1897)
  • 03a7078 [doc] Remove unsafe regex from code snippet
  • 7ee3115 [doc] Add logo to coverage badge
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 28, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.5.0 branch 6 times, most recently from 628a83f to a1c176d Compare June 28, 2021 06:56
@mdreizin
Copy link
Owner

@dependabot rebase

@mdreizin mdreizin enabled auto-merge (squash) June 28, 2021 07:11
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.5.0 branch 2 times, most recently from 26b3a21 to c1e7b2b Compare June 28, 2021 07:16
@mdreizin mdreizin disabled auto-merge June 28, 2021 07:38
@mdreizin mdreizin enabled auto-merge (squash) June 28, 2021 07:38
@mdreizin
Copy link
Owner

@dependabot rebase

Bumps [ws](https://github.com/websockets/ws) from 7.4.0 to 7.5.0.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.0...7.5.0)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.5.0 branch from c1e7b2b to 1c0b78f Compare June 28, 2021 07:39
@mdreizin mdreizin merged commit 99e9086 into main Jun 28, 2021
@mdreizin mdreizin deleted the dependabot/npm_and_yarn/ws-7.5.0 branch June 28, 2021 07:54
@github-actions
Copy link

🎉 This PR is included in version 1.6.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant