Switching to ScaleFT/sshkeys for reading (encrypted) key data. #8

dhermes · 2019-01-17T07:01:50Z

This is a follow-on to #7. A few notes:

There are no tests, what should I do to test this?
Should I update references to Go 1.9 to be Go 1.11?
To verify this is correct, should I run make.sh?
Where should I add the dependency on ScaleFT/sshkeys?

Thanks

dhermes · 2019-01-17T07:02:25Z

server.go

+	passphrase := []byte(config.Pwd)
+	var privateKey interface{}
+	fmt.Println("Decrypting private key with passphrase...")
+	privateKey, err = sshkeys.ParseEncryptedRawPrivateKey(keyData, passphrase)


Note that if passphrase is empty, this will still work provided the key isn't actually encrypted (i.e. the name ParseEncryptedRawPrivateKey is a bit misleading, since the Encrypted isn't strictly necessary)

dhermes · 2019-02-07T05:25:17Z

@benton Gentle nudge. I'd love to discuss / see what you have to say about the direction of this PR.

I initially thought the BEGIN OPENSSH PRIVATE KEY was just "Apple being Apple" but I realized it's a new format from the openssh maintainers:

The OpenSSH format, supported in OpenSSH releases since 2014 and described in the PROTOCOL.key file in the source distribution, offers substantially better protection against offline password guessing and supports key comments in private keys

Switching to ScaleFT/sshkeys for reading (encrypted) key data.

772c2b1

dhermes commented Jan 17, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switching to ScaleFT/sshkeys for reading (encrypted) key data. #8

Switching to ScaleFT/sshkeys for reading (encrypted) key data. #8

dhermes commented Jan 17, 2019 •

edited

Loading

dhermes Jan 17, 2019 •

edited

Loading

dhermes commented Feb 7, 2019 •

edited

Loading

Switching to ScaleFT/sshkeys for reading (encrypted) key data. #8

Are you sure you want to change the base?

Switching to ScaleFT/sshkeys for reading (encrypted) key data. #8

Conversation

dhermes commented Jan 17, 2019 • edited Loading

dhermes Jan 17, 2019 • edited Loading

Choose a reason for hiding this comment

dhermes commented Feb 7, 2019 • edited Loading

dhermes commented Jan 17, 2019 •

edited

Loading

dhermes Jan 17, 2019 •

edited

Loading

dhermes commented Feb 7, 2019 •

edited

Loading