feat: Add aria-label to CreateLink button #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should use the translation I believe? |
I have few more changes to this PR, I will push those in an hour |
done |
can we merge this by today ? |
|
No. It fails the prettier check. I will add the change as a part of a larger commit. |
I have made the changes, now it won't fail, kindly check because i need this for a task as soon as possible. |
|
🎉 This PR is included in version 3.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
petyosi
added a commit
that referenced
this pull request
Jun 22, 2024
resolves #495 Squashed commit of the following: commit 4cac17b0d31fe88731cc6f5275c83e049bec9fef Author: Petyo Ivanov <underlog@gmail.com> Date: Sat Jun 22 07:21:14 2024 +0300 chore: eslint commit 54bee8223588ac082a2cf58c3a4d342e13745a07 Author: Dharanish V <30527938+dharanish-v@users.noreply.github.com> Date: Fri Jun 14 22:38:47 2024 +0530 fix: add aria-label to CreateLink button (#492) * feat: Add aria-label to CreateLink button * feat: Update CreateLink button aria-label for localization * feat: Update CreateLink button aria-label for localization commit e427be8 Author: Adriano Scazzola <adriano.scazzola@gmail.com> Date: Thu Jun 13 14:28:55 2024 -0300 Add property to display / hidde buttons on BoldItalicUnderlineToggles plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aria-label to improve accessibility
closes #493