Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: performance improvement via cache #306

Merged
merged 1 commit into from
Apr 26, 2021
Merged

feat: performance improvement via cache #306

merged 1 commit into from
Apr 26, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 26, 2021

No description provided.

@JounQin JounQin added 🦋 type/enhancement This is great to have internal :house: Internal 🏡 area/internal This affects the hidden internals labels Apr 26, 2021
@JounQin JounQin self-assigned this Apr 26, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

wooorm
wooorm approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Again, not an expert on the code base, but it seems okay?

@JounQin
Copy link
Member Author

JounQin commented Apr 26, 2021

@wooorm Is there an open API from remark itself to resolve its config?

@wooorm
Copy link
Member

wooorm commented Apr 26, 2021 •
edited
Loading

unified-engine does all that stuff, specifically, this file: https://github.com/unifiedjs/unified-engine/blob/9bd9c30ffb4e0e3b28c06451e40ea429abf95662/lib/configuration.js#L28. Configuration is here: https://github.com/remarkjs/remark/blob/80658e9e601452f0d97fa71ba8b7ba1ed43cdec7/packages/remark-cli/cli.js#L11-L23.

There’s some chatter on updating to use cosmiconfig or so soon, though: remarkjs/remark#654.

Also: I’m rewriting everything in ESM + JSDoc based TS right now. So expect types added there in the near future too.

@JounQin JounQin merged commit a893aa7 into master Apr 26, 2021
@JounQin JounQin deleted the feat/perf branch April 26, 2021 16:49
@JounQin JounQin added the 🏁 area/perf This affects performance label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm wooorm approved these changes

Assignees

@JounQin JounQin

Labels
🏡 area/internal This affects the hidden internals 🏁 area/perf This affects performance internal :house: Internal 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JounQin @wooorm @ChristianMurphy