Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle references to generated code #284

Closed
4 tasks done
remcohaszing opened this issue Jan 22, 2023 · 1 comment · Fixed by #340
Closed
4 tasks done

Handle references to generated code #284

remcohaszing opened this issue Jan 22, 2023 · 1 comment · Fixed by #340
Labels
💪 phase/solved Post is done

Comments

@remcohaszing
Copy link
Member

Initial checklist

Affected packages and versions

1.1.0

Link to runnable example

No response

Steps to reproduce

Create an MDX file with just markdown content.

Expected behavior

Nothing

Actual behavior

A diagnostic is generated, saying props is unused.

This affects other to-be-determined request types too.

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

remcohaszing added a commit that referenced this issue Aug 18, 2023
- Volar handles the mapping between TypeScript and LSP.
- Volar handles the mapping between TypeScript and Monaco editor.
- Volar manages virtual files.
- Volar imports TypeScript directly. As a result, the Monaco editor
  integration now requires `path` to be polyfilled.
- It is no longer possible to pass compiler options in the Monaco editor
  integration.
- This adds editor features for YAML based on `yaml-language-server`.
  This has been contributed upstream to Volar and is pending review.
- Markdown features are now handled by
  `vscode-markdown-languageservice`. This will be contributed upstream
  to Volar soon.
- Markdown definitions are broken due to a bug in Volar.
- This adds `remark-frontmatter` with TOML and YAML support as well as
  `remark-gfm` by default unless specified otherwise in `tsconfig.json`.
- The language server now requires `typescript.tsdk` to be passed via
  initialization options.
- This adds support for debugging virtual documents using Volar labs.

Closes #168
Closes #284
Closes #295
Closes #298
Closes #301
remcohaszing added a commit that referenced this issue Oct 23, 2023
- Volar handles the mapping between TypeScript and LSP.
- Volar handles the mapping between TypeScript and Monaco editor.
- Volar manages virtual files.
- Volar imports TypeScript directly. As a result, the Monaco editor integration now requires `path` to be polyfilled.
- `@mdx-js/monaco` is deprecated and removed.
- This adds `remark-frontmatter` with TOML and YAML support as well as `remark-gfm` by default unless specified otherwise in `tsconfig.json`.
- The language server now requires `typescript.tsdk` to be passed via initialization options.
- This adds support for debugging virtual documents using Volar labs.

Closes #168
Closes #284
Closes #295
Closes #298
Closes #301

Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
@remcohaszing
Copy link
Member Author

Released in vscode-mdx@1.5.0, @mdx-js/language-server@0.2.0 🎉

@wooorm wooorm added the 💪 phase/solved Post is done label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging a pull request may close this issue.

2 participants