Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support remark plugins in Monaco and demo #304

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Support remark plugins in Monaco and demo #304

merged 1 commit into from
Feb 24, 2023

Conversation

remcohaszing
Copy link
Member

Closes #264

@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on labels Feb 23, 2023
@remcohaszing remcohaszing requested a review from a team February 23, 2023 14:47
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

⚠️ No Changeset found

Latest commit: 84e0ca7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ChristianMurphy
ChristianMurphy approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @remcohaszing!

@remcohaszing remcohaszing merged commit 19519c3 into main Feb 24, 2023
@remcohaszing remcohaszing deleted the monaco-remark-plugins branch February 24, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support remark syntax plugins in @mdx-js/monaco
2 participants
@remcohaszing @ChristianMurphy