Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dragging uri-list into MDX files #346

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Handle dragging uri-list into MDX files #346

merged 2 commits into from
Nov 7, 2023

Conversation

remcohaszing
Copy link
Member

A mime type of uri-list is for example files dragged from the VSCode tree view.

Images are turnes into Markdown images. These are detected based on a hardcoded list of file extensions. Other URIs are inserted as-is.

If the dragged URI uses the same scheme as the document it was dragged in, a relative path is inserted. Otherwise the full URI is used.

Closes #322

@remcohaszing
Handle dragging uri-list into MDX files
271a5b3 
A mime type of `uri-list` is for example files dragged from the VSCode
tree view.

Images are turnes into Markdown images. These are detected based on a
hardcoded list of file extensions. Other URIs are inserted as-is.

If the dragged URI uses the same scheme as the document it was dragged
in, a relative path is inserted. Otherwise the full URI is used.

Closes #322
@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change 👍 phase/yes Post is accepted and can be worked on labels Oct 30, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2501e84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing merged commit 6f873ba into main Nov 7, 2023
@remcohaszing remcohaszing deleted the drop-edit-relative-uri-list branch November 7, 2023 15:07
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Nov 7, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Nov 7, 2023
@karlhorky
Copy link

Amazing, thanks @remcohaszing and @ChristianMurphy 🙌

@karlhorky karlhorky mentioned this pull request Dec 21, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drag and Drop to create Markdown images in MDX files
3 participants
@remcohaszing @karlhorky @ChristianMurphy