Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update some outdated links #380

Merged
merged 1 commit into from
Dec 22, 2023
Merged

docs: update some outdated links #380

merged 1 commit into from
Dec 22, 2023

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 22, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

As title

Signed-off-by: JounQin <admin@1stg.me>
@JounQin JounQin requested a review from remcohaszing December 22, 2023 15:02
Copy link

changeset-bot bot commented Dec 22, 2023

⚠️ No Changeset found

Latest commit: b90d4a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 22, 2023

This comment has been minimized.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 22, 2023
@JounQin
Copy link
Member Author

JounQin commented Dec 22, 2023

cc @remcohaszing

No idea why the CI is failing.

@remcohaszing
Copy link
Member

Thanks! I wonder if we shouldn’t remove or at least trim down this section though. It feels like the wrong place to document how to use ESLint with MDX, except for the eslint.validate setting.

@remcohaszing
Copy link
Member

Don’t worry about the CI failure. That’s my fault, not related to this PR.

@remcohaszing
Copy link
Member

I will merge this as-is, because updating the links is a good change on its own.

@remcohaszing remcohaszing merged commit d09da13 into main Dec 22, 2023
2 of 10 checks passed
@remcohaszing remcohaszing deleted the JounQin-patch-1 branch December 22, 2023 15:36

This comment has been minimized.

@remcohaszing remcohaszing added 📚 area/docs This affects documentation 🦋 type/enhancement This is great to have 👶 semver/patch This is a backwards-compatible fix 💪 phase/solved Post is done labels Dec 22, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 22, 2023
@JounQin
Copy link
Member Author

JounQin commented Dec 22, 2023

Thanks! I wonder if we shouldn’t remove or at least trim down this section though. It feels like the wrong place to document how to use ESLint with MDX, except for the eslint.validate setting.

I believe that is a good place to document such related tools together in one place considering it's short enough. It would be easier to be found for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants