-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more options to playground, directives, format, etc #2295
Merged
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d92eed1
add support for remark-directive + format md
slorber a4a194d
Add ability to remove ast positions by default
slorber ef61762
Update docs/_component/editor.client.js
slorber ca34275
Use radio for format option
slorber 8142872
Add ability to remove esast positional infos
slorber d478105
import order
slorber 748281f
Merge branch 'main' into slorber/playground-format-md
slorber 07a1ddb
Add rehype-raw option
slorber 62ea85d
remove useless export
slorber bbc84f5
Update docs/_component/editor.client.js
slorber 68d707d
Merge branch 'slorber/playground-format-md' of github.com:slorber/mdx…
slorber 3e1b89e
Merge branch 'main' into slorber/playground-format-md
slorber 90409dc
use clear range for remark-directive
slorber 8a1b0ff
add rehypeRaw passThrough
slorber cc12b73
move removePositionEsast at the bottom of the file
slorber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export
? Don’t think that’s neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the export, typo
Not sure what you mean by "calls first", isn't it already the case? I used the code style found in
unist-util-remove-position
Or is it the top-level fn declaration that I should put at the bottom of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I mean, place it in the highest scope, at the bottom!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
But It was already at the highest scope, and useMdx() is at the top. So we have one helper fn above and under the default exported component 🤪