Update AsyncWebSocket.cpp #1142
Conversation
Fix compile error for ESP32-C3 toolchain ( ambiguous type)
|
I wanted to push this as well. I was unable to get the most recent release to work with my ESP32-C3 project, and this branch compiled without issue. |
|
Thanks. The Marlin Firmware greatly appreciates your compatibility work. (MarlinFirmware/Marlin#25327) |
…32 to fix compilation issues on the latest Espressif toolchains When the PR luc-github/ESP3DLib#51 has been merged then please change it back! - (temporarily) updated the "ESP Async WebServer" dependency for MKS TinyBee / ESP32 to fix compilation issues on the latest Espressif toolchains Please watch PR me-no-dev/ESPAsyncWebServer#1142 and change back once merged. - fixed another ESP32 bug due to toolchain update
|
Please rename the subject of this issue to "Fix compilation error on RISC-V processor ESP32-C3" |
|
related #970 |
| @@ -829,7 +829,7 @@ void AsyncWebSocketClient::binary(AsyncWebSocketMessageBuffer * buffer) | |||
|
|
|||
| IPAddress AsyncWebSocketClient::remoteIP() { | |||
| if(!_client) { | |||
| return IPAddress(0U); | |||
| return IPAddress((uint32_t)0); | |||
There was a problem hiding this comment.
It'd be great to get this merged some day. There seems to be a whole history of people forking the lib to fix this one line!
I'm using current libs and modern platformio with a ESP32 chip and this error is a hard blocker for using this library (from original source) at all.
The overload with no arguments defaults to a zero address, so I'd suggest leaving the address out altogether...
| return IPAddress((uint32_t)0); | |
| return IPAddress(); |
Both work though, so 🤷
Fix compile error for ESP32-C3 RISC-V toolchain ( ambiguous type)
Original compile error :
xxx/ESPAsyncWebServer/src/AsyncWebSocket.cpp:832:28: error: call of overloaded 'IPAddress(unsigned int)' is ambiguous
return IPAddress(0U);
^
xxx/.arduino15/packages/esp32/hardware/esp32/2.0.1/cores/esp32/IPAddress.h:51:5: note: candidate: 'IPAddress::IPAddress(const uint8_t*)'
IPAddress(const uint8_t *address);
^~~~~~~~~
xxx/.arduino15/packages/esp32/hardware/esp32/2.0.1/cores/esp32/IPAddress.h:50:5: note: candidate: 'IPAddress::IPAddress(uint32_t)'
IPAddress(uint32_t address);