test: resubscribe to a hub with new curve #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parv3213
commented
Feb 2, 2022
parv3213
commented
Feb 2, 2022
| ); | ||
| const burnOwnerFee = 1e8; | ||
| const burnBuyerFee = 1e9; | ||
| const stepX = ethers.utils.parseEther("2"); |
There was a problem hiding this comment.
Check for stepX and stepY values.
There was a problem hiding this comment.
I mean, check if these values are fit for the test. For example, I tried setting StepY = 5e18, and the tests failed with Error: VM Exception while processing transaction: reverted with panic code 0x11 (Arithmetic operation underflowed or overflowed outside of an unchecked block)
pegahcarter
reviewed
Feb 3, 2022
pegahcarter
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.