Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending tests and style improvements #126

Merged
merged 7 commits into from
Feb 26, 2022
Merged

Pending tests and style improvements #126

merged 7 commits into from
Feb 26, 2022

Conversation

parv3213
Copy link
Member

@parv3213
Copy link
Member Author

parv3213 commented Feb 25, 2022 •
edited by pegahcarter
Loading

TODO / Review

@pegahcarter
Copy link
Member

@parv3213 I'll take care of those TODOs in #122

@pegahcarter
Copy link
Member

@parv3213 why is https://github.com/meTokens/meTokens-core/blob/main/contracts/libs/LibWeightedAverage.sol#L30 dead

@parv3213
Copy link
Member Author

@parv3213 why is https://github.com/meTokens/meTokens-core/blob/main/contracts/libs/LibWeightedAverage.sol#L30 dead

Because there is no condition when that case will run. This https://github.com/meTokens/meTokens-core/blob/main/contracts/libs/LibWeightedAverage.sol#L28 condition will never be true, as LibWeightedAverage is never called when blocktime > endTime.

@pegahcarter pegahcarter merged commit 0e4427d into main Feb 26, 2022
@pegahcarter pegahcarter deleted the test/pending-tests branch March 8, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pegahcarter pegahcarter pegahcarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parv3213 @pegahcarter