Mint/burn first handle Resubscribe and then finish Hub update #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue: 6. [LibFoundry.sol] An unassigned variable exists
- remove `cooldown` in LibHub.sol - commented `transferFee`, `interestFee` and `yieldFee`. and all related functions
- Issue: 6. [LibFoundry.sol] An unassigned variable exists
- remove `cooldown` in LibHub.sol - commented `transferFee`, `interestFee` and `yieldFee`. and all related functions
parv3213
approved these changes
Jul 6, 2022
pegahcarter
requested changes
Jul 6, 2022
- related to transferFee, interestFee, yieldFee
pegahcarter
reviewed
Jul 7, 2022
Chainlink Slippage tests
Fix/chainlink
pegahcarter
approved these changes
Jul 12, 2022
|
Chainlink tests done to ensure migration swap happens with less than 5% slippage. The following tests pass within that slippage range:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following tests to check the above change:
-> Mint: when resubscribing and updating- Poke or finish resubscribe should be called first and then finishUpdate.
-> Burn: when resubscribing and updating- Poke or finish resubscribe should be called first and then finishUpdate.
-> Burn: when resubscribing and updating- calculateActualAssetsReturned should calculate actualAssetsReturned with resubscribing formula.