Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/me token registry #24

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Test/me token registry #24

merged 2 commits into from
Sep 27, 2021

Conversation

zgorizzo69
Copy link
Collaborator

  • add util functions for contract deploy and getcontractAt
  • start MeTokenRegistry tests

@@ -22,6 +22,7 @@ contract BancorZeroCurve is ICurve, Power {
override
{
// TODO: access control
require(_encodedValueSet.length > 0, "ValueSet empty");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

await vaultRegistry.approve(singleAssetFactory.address);

await hub.initialize(
foundry.address,
vaultRegistry.address,
curveRegistry.address
);
const encodedValueSet = ethers.utils.defaultAbiCoder.encode(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, ty

import { Libraries } from "@nomiclabs/hardhat-ethers/types";
import { ethers } from "hardhat";

export async function deploy<Type>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@pegahcarter pegahcarter merged commit dbbf402 into feat/typescript Sep 27, 2021
@pegahcarter pegahcarter deleted the test/MeTokenRegistry branch September 27, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants