-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/me token registry #24
Conversation
zgorizzo69
commented
Sep 27, 2021
- add util functions for contract deploy and getcontractAt
- start MeTokenRegistry tests
@@ -22,6 +22,7 @@ contract BancorZeroCurve is ICurve, Power { | |||
override | |||
{ | |||
// TODO: access control | |||
require(_encodedValueSet.length > 0, "ValueSet empty"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
await vaultRegistry.approve(singleAssetFactory.address); | ||
|
||
await hub.initialize( | ||
foundry.address, | ||
vaultRegistry.address, | ||
curveRegistry.address | ||
); | ||
const encodedValueSet = ethers.utils.defaultAbiCoder.encode( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, ty
import { Libraries } from "@nomiclabs/hardhat-ethers/types"; | ||
import { ethers } from "hardhat"; | ||
|
||
export async function deploy<Type>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3