test: add incomplete tests #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanted to check events with args on:
but this is failing as |
This comment was marked as outdated.
This comment was marked as outdated.
parv3213
commented
Jan 3, 2022
| toETHNumber( | ||
| meTokenDetails.balanceLocked.sub(newMeTokenDetails.balanceLocked) | ||
| ) | ||
| ).to.be.approximately(lockedAmount, 1e-13); |
There was a problem hiding this comment.
@carlfarterson @zgorizzo69 here the precision is lesser than usual, 1e-15. As these calculations don't require a timestamp, I am not sure why there is less precision.
Note: when this file is tested separately the calculations are exactly matching.
There was a problem hiding this comment.
indeed I am able to reproduce
There was a problem hiding this comment.
Thoughts on why this is failing? @zgorizzo69 ?
parv3213
force-pushed
the
test/incomplete-tests
branch
from
5aec6bf
to
6df2ee0
Compare
|
@carlfarterson @zgorizzo69 this can be merged now |
zgorizzo69
approved these changes
Feb 7, 2022
| toETHNumber( | ||
| meTokenDetails.balanceLocked.sub(newMeTokenDetails.balanceLocked) | ||
| ) | ||
| ).to.be.approximately(lockedAmount, 1e-13); |
There was a problem hiding this comment.
indeed I am able to reproduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.