Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: diamond storage #94

Merged
merged 77 commits into from
Feb 16, 2022
Merged

refactor: diamond storage #94

merged 77 commits into from
Feb 16, 2022

Conversation

pegahcarter
Copy link
Member

No description provided.

@pegahcarter pegahcarter changed the title feat: diamond storage refactor: diamond storage Jan 7, 2022
@zgorizzo69
Copy link
Collaborator

zgorizzo69 commented Jan 12, 2022

you went for the diamond-3 the implementation is easier to read than diamond-2 but I wonder how much gas we could save by using diamond2 to CRUD facets.
to access them it should be quite similar cos we have in v3

 address facet = ds.selectorToFacetAndPosition[msg.sig].facetAddress;

and in v2

 address facet = address(bytes20(ds.facets[msg.sig]));

@zgorizzo69
Copy link
Collaborator

we should also add a test to upgrade each facets and make sure the data is still accessible

Carl Farterson and others added 28 commits February 1, 2022 10:29
- MeToken: getDetails -> getMeTokenDetails
- Curve: getDetails -> getCurveDetails
- Hub: getDetails -> getHubDetails
feat(meta): replace msg.sender
Revert "feat(meta): replace msg.sender"
@pegahcarter pegahcarter merged commit 0d803bd into main Feb 16, 2022
@pegahcarter pegahcarter deleted the diamond branch March 8, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants