Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arg parsing for --suite <name> #101

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Fix arg parsing for --suite <name> #101

merged 1 commit into from
Jul 14, 2018

Conversation

bwhite-mdsol
Copy link
Contributor

@bwhite-mdsol bwhite-mdsol commented Jul 13, 2018 •
edited
Loading

Without the opts param to OptionParser.parse/2, the suite name is not properly parsed and the selected suite is not run, instead the first suite in the config is run when invoked via:

MIX_ENV=test mix white_bread.run --suite Pack

meadsteve
meadsteve approved these changes Jul 14, 2018
View reviewed changes
Copy link
Collaborator

@meadsteve meadsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍

@meadsteve meadsteve merged commit 0c336a9 into meadery:master Jul 14, 2018
@meadsteve
Copy link
Collaborator

Release as 4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meadsteve meadsteve meadsteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwhite-mdsol @meadsteve