Run scenario setup for outlines just like we do for simple scenarios #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see that Travis isn't happy. Let me fix those issues. |
|
There we go. Travis likes it now. :) |
meadsteve
requested changes
Dec 4, 2016
| @@ -0,0 +1,5 @@ | |||
| defmodule WhiteBread.Runners.Utilities do | |||
| def apply_scenario_starting_state(feature_state, context) do | |||
There was a problem hiding this comment.
Nice idea. I like this being extracted 👍
There was a problem hiding this comment.
Great! There's probably more duplication that could be reduced.
Conflicts: lib/white_bread/runners/scenario_outline_runner.ex
|
I resolved the merge conflicts. Possibly even correctly. :D |
meadsteve
pushed a commit
that referenced
this pull request
Dec 5, 2016
…76) * Add basic scenario testing outline functionality. [#73] * Load starting state in scenario outlines. [#73] * Verify that we reload the starting state for each example. [#73] * Fix failing test. [#73] * Extract a utility module for duplication. [#73] * Update changelog. [#73] * Reorganize directories so white_bread doesn't get confused about which context to use. [#73] * Make tests compatible with Elixir 1.1. [#73]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug described in #73.