Upgrade Gherkin to 1.4 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leifg
force-pushed
the
change-data-table-format
branch
2 times, most recently
from
30b2f12 to
8fd097b
Compare
|
Needs a bit of tidying after #91 was merged but initially looks 👍 |
since [this commit](cabbage-ex/gherkin@1cf8f73) in gherkin, the data tables are provided in the right format, so no need to convert them.
gherkin 1.4 does not support 1.1 anymore
leifg
force-pushed
the
change-data-table-format
branch
from
8fd097b to
e2a778d
Compare
|
Cleanup done |
|
PR that removes lines of code. That's 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since [this commit](cabbage-ex/gherkin@1cf8f73 in gherkin, the data tables are provided in the right format, so no need to convert them.