Add json formatter #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meadsteve
requested changes
Sep 8, 2017
| @@ -2,4 +2,5 @@ | |||
| "credo": {:hex, :credo, "0.8.6", "335f723772d35da499b5ebfdaf6b426bfb73590b6fcbc8908d476b75f8cbca3f", [:mix], [{:bunt, "~> 0.2.0", [hex: :bunt, repo: "hexpm", optional: false]}], "hexpm"}, | |||
| "earmark": {:hex, :earmark, "1.2.3", "206eb2e2ac1a794aa5256f3982de7a76bf4579ff91cb28d0e17ea2c9491e46a4", [:mix], [], "hexpm"}, | |||
| "ex_doc": {:hex, :ex_doc, "0.16.3", "cd2a4cfe5d26e37502d3ec776702c72efa1adfa24ed9ce723bb565f4c30bd31a", [:mix], [{:earmark, "~> 1.1", [hex: :earmark, repo: "hexpm", optional: false]}], "hexpm"}, | |||
| "gherkin": {:hex, :gherkin, "1.4.0", "b7b6a80029725a4b29a1c58f96ddb3fa9409d4fa907503384b1f86392491fcd0", [:mix], [], "hexpm"}} | |||
| "gherkin": {:hex, :gherkin, "1.4.0", "b7b6a80029725a4b29a1c58f96ddb3fa9409d4fa907503384b1f86392491fcd0", [:mix], [], "hexpm"}, | |||
There was a problem hiding this comment.
What do you think of marking poison as :optional? It's only required for anyone actually using the json formatter
leifg
force-pushed
the
add-json-formatter
branch
from
815874c to
98349d5
Compare
this makes it possible to have any kind of output by using tools like the [cucumber-html-reporter](https://github.com/gkushang/cucumber-html-reporter)
leifg
force-pushed
the
add-json-formatter
branch
3 times, most recently
from
226e04c to
13ea380
Compare
leifg
force-pushed
the
add-json-formatter
branch
from
13ea380 to
b0a9018
Compare
meadsteve
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it possible to have any kind of output by using tools like the cucumber-html-reporter