Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] [Task] - Remove Remaining Non-Paginated Recipe Requests #2118

Closed
hay-kot opened this issue Feb 12, 2023 · 2 comments · Fixed by #2174
Closed

[v1.0.0b] [Task] - Remove Remaining Non-Paginated Recipe Requests #2118

hay-kot opened this issue Feb 12, 2023 · 2 comments · Fixed by #2174
Labels
task General Task that needs to be completed v1 Version 1 Issue/PR

Comments

@hay-kot
Copy link
Collaborator

hay-kot commented Feb 12, 2023

What is the problem this task addresses?

Issue outlined in

Proposed/Possible Solution(s)?

Two areas still need to be updated

  1. Data Management

https://github.com/hay-kot/mealie/blob/feat/server-side-search/frontend/pages/group/data/recipes.vue#L181

  1. Meal Planner

https://github.com/hay-kot/mealie/blob/feat/server-side-search/frontend/pages/group/mealplan/planner.vue#L306

@hay-kot hay-kot added task General Task that needs to be completed v1 Version 1 Issue/PR labels Feb 12, 2023
@hay-kot hay-kot added this to the v1.0.0beta-RC1 milestone Feb 20, 2023
@fleshgolem
Copy link
Contributor

So the second part was simple enough, but the first really isnt and poses some further questions
We could rewrite the data-table to use server-side pagination, which thankfully is simple enough in vuetify, and implement that similarly to the RecipeCardSection. This is pretty straightforward for the most part, however ordering by categories/tags/tools isnt really possible with the api as it is right now. You could scrap that, but that probably limits the usefulness of this page
So to do this properly we would need to add ordering by these parameters to the api, but to me it isnt even clear how exactly that should work in the first place, it kind of automagically does in the data-table, but i am not sure what it does exactly
Additionally, if we are changing this page that much to begin with, wouldnt it be useful to maybe add a search field here as well, to be able to really dig for certain recipes?
Overall I think this warrants a standalone issue that is fleshed out a bit more. I also dont think this necessarily needs to be a blocker for v1. This is really not a page you should need to visit very often and in the cases where you do a lot of work here and have a huge collection, it might just be ok for now to maybe wait a few seconds

@hay-kot
Copy link
Collaborator Author

hay-kot commented Feb 24, 2023

This is pretty straightforward for the most part, however ordering by categories/tags/tools isnt really possible with the api as it is right now. You could scrap that, but that probably limits the usefulness of this page

So to do this properly we would need to add ordering by these parameters to the api, but to me it isnt even clear how exactly that should work in the first place, it kind of automagically does in the data-table, but i am not sure what it does exactly

I don't think sorting by category/tag/tool is really necessary at all. What I really want when I do that is to see Recipes that don't have those defined at all. So if we had filters for "Show recipes with null Categories" etc... that would fulfill the require IMO.

Additionally, if we are changing this page that much to begin with, wouldn't it be useful to maybe add a search field here as well, to be able to really dig for certain recipes?

That's a super valid point. In reality we could reuse the search logic and components via a composable or something to get most of the behavior we're looking for without too much rework.

Overall I think this warrants a standalone issue that is fleshed out a bit more. I also dont think this necessarily needs to be a blocker for v1. This is really not a page you should need to visit very often and in the cases where you do a lot of work here and have a huge collection, it might just be ok for now to maybe wait a few seconds

I can agree with that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task General Task that needs to be completed v1 Version 1 Issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants