Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface unusable with 5,000+ recipes #2076

Closed
domini17 opened this issue Jan 29, 2023 · 5 comments
Closed

Interface unusable with 5,000+ recipes #2076

domini17 opened this issue Jan 29, 2023 · 5 comments
Labels

Comments

@domini17
Copy link

Really love this software. It's entirely possible my niche use case is simply out of scope of any intended usage. Loaded 5000+ recipes into Mealie (w/ postgresql backend + RAM / CPU up the wazoo) via the API and the software just takes 5+ minutes to navigate between pages.

@michael-genson
Copy link
Collaborator

Wow, that's a lot of recipes!
There are a few major optimizations coming down the pipeline soon, so look out for a new version on nightly and see if performance improves for you. It should be pretty drastic.

See PR #2062 and PR #2070

@fleshgolem
Copy link
Contributor

Huh, thats interesting...
So, #2070 shouldnt really do anything performance-wise, #2062 should alleviate this at least a little bit, but I'm still surprised that things are this bad in the first place since everything is paginated and never loads more than ~64 recipes at once, so this really shouldnt ever take that long unless something else is really fucked up.
My gut says that there are probably places where the database is not indexed properly somewhere (i never really checked for that, when doing the last performance thing, for some reason) otherwise loading times shouldnt grow like that. I can take a look at it at some point in the next few days, I think, I just need to find some quick way to generate this amount of data in the first place :). If you are in the discord and know how-to and are comfortable with sharing a dump of your database (you can remove the users table of course), feel free to contact me. Otherwise it will probably take a bit longer

The only part of the app that I assume will be unsalvagable as of right now is the search, as that always tries to load the full dataset and does things client-side

@fleshgolem
Copy link
Contributor

I talked to @domini17 on discord and it turns out they were using 0.5.6, so I assume noone has any interest in improving things on that end
I could still find some issues with the current setup, but these would cause a page load with 5000 recipes to be more around 1-2sec rather than the mentioned 5 minutes. Still not ideal, but probably out of scope of this issue, so i will do a followup one

@hay-kot
Copy link
Collaborator

hay-kot commented Feb 12, 2023

Fixes the majority of these issues you'll see with this kind of volume. There are two more areas that need to still be fixed. See here for the list and tracking.

@hay-kot hay-kot added this to the v1.0.0beta-RC1 milestone Feb 20, 2023
@hay-kot hay-kot removed this from the v1.0.0beta-RC1 milestone Mar 15, 2023
@stale
Copy link

stale bot commented May 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 15, 2023
@stale stale bot closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants