-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sqlalchemy 2.0 #2070
Closed
fleshgolem
wants to merge
12
commits into
mealie-recipes:mealie-next
from
fleshgolem:feature/sqlalchemy_2_0
Closed
Feature/sqlalchemy 2.0 #2070
fleshgolem
wants to merge
12
commits into
mealie-recipes:mealie-next
from
fleshgolem:feature/sqlalchemy_2_0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to resolve the conflicts over in #2096 but I exploded something :( Will try to fix later this week. Amazing work in the PR really stoked you went through this. I was dreading it |
Changes incorporated in #2096 - Thanks so much for all the work on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Well... these changes allow migration to sqlalchemy 2.0, that part should be obvious
Truth be told, only very few of these changes are needed to actually make it work, neither the new mapping declarations nor the 2.0 style querying are needed (at least of right now) for the app to still work.
However
So in the end, IMO this is probably as good as a time as any to move everything to the new APIs
Which issue(s) this PR fixes:
The errors in #2061 i guess
Special notes for your reviewer:
If you are not comfortable with all these changes right now and just want sqlalchemy 2.0 to work, all necessary changes are in 07e14b2 in the files
db_setup.py
,model_base.py
andauto_init.py
Testing
I made sure all automated tests still work the same as before. I also tried to test as many things as I can with the locally running frontend. This app has a lot of features however and I would assume that I missed to test something somewhere, so it might not be the worst idea to have another round of manual testing before merging this
Release Notes