feat: Bulk deletion on "Manage Data" page #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
changed the title
hay-kot
approved these changes
Feb 4, 2024
|
Uff, how did I not see that. Was looking at them yesterday. Nice catch! Guess this fixes #2862 then? |
I think so! |
michael-genson
approved these changes
Feb 4, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This adds bulk deletion functionality to all remaining tabs (recipes already had that functionality) in the Manage Data page.
Especially with the upcomming pr #3037 that significantly increases the size of our seed database it might be a welcome inclusion to be able to delete data without having to manually delete a large amount of items one by one.
Which issue(s) this PR fixes:
Closes #2862
Special notes for your reviewer:
I had to change a bit of the CrudTable bulkAction logic to reset the selected items on execution, but as the CrudTable is not used anywhere else it should not break anything.
Not directly concerning this pr, but the individual manage data pages are reusing a lot of code again and again so we should put more of that in a components (already working on that).
Testing
Manual testing.