Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support HEIF, HEIC and AVIF recipe image uploads #3409

Merged

Conversation

tba-code
Copy link
Contributor

@tba-code tba-code commented Apr 2, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

  • Pillow does not natively support HEIF as seen here.
  • Apple products use .heic.
  • This PR Adds support for HEIF files (.heif, .heic, .avif). via pi-heif.

Which issue(s) this PR fixes:

Fixes #3393

Testing

Manually tested by downloading an heic image from the internet and uploading it to a test recipe in Mealie.

@tba-code
Copy link
Contributor Author

tba-code commented Apr 4, 2024

Thanks for pointing out my mistake here. I have fixed it and avif support is now properly included. Please try again.

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@michael-genson michael-genson merged commit 9fade36 into mealie-recipes:mealie-next Apr 4, 2024
10 checks passed
@tba-code tba-code deleted the feat-heif-support branch April 5, 2024 01:59
anoadragon453 added a commit to anoadragon453/nixpkgs that referenced this pull request May 7, 2024
* authlib was required in v1.4.0
  (mealie-recipes/mealie#3280)
* pillow-heif was required in v1.5.0
  (mealie-recipes/mealie#3409)
* pydantic-settings was required in v1.3.0
  (mealie-recipes/mealie#3134 - same PR as
  pydantic v2 bump)
* pyjwt was required in v1.6.0
  (mealie-recipes/mealie#3521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Support for HEIC images
2 participants