Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Internationalize sent emails #3818

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

p0lycarpio
Copy link
Contributor

@p0lycarpio p0lycarpio commented Jun 29, 2024

What type of PR is this?

(REQUIRED)

  • feature

What this PR does / why we need it:

(REQUIRED)

This PR adds internationalization to Mealie on emails sent by Mealie depending on the language of the user who triggers the action via the frontend.

Which issue(s) this PR fixes:

(REQUIRED)

N/A

Special notes for your reviewer:

The user's language is retrieved using the accept_language header sent by the front. If the language is not specified or the JSON file does not exist, Mealie uses the en-US locale by default.

Contributors will be able to translate english strings from Crowdin after the merge.

Testing

(fill-in or delete this section)

  • Manually (via sending and log tests).
  • Launching task py:tests

@Kuchenpirat
Copy link
Collaborator

Hey, thanks for your work on this.

Before I have time to look at it a first note, please add new translation only to the en-us file, the rest will be handled by crowdin.

@boc-the-git boc-the-git enabled auto-merge (squash) July 20, 2024 10:25
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good mate, thanks!

@boc-the-git boc-the-git merged commit 60c33b4 into mealie-recipes:mealie-next Jul 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants