fix: Offline Shopping List Fixes V2 - Electric Boogaloo #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…shopping-list-fixes-v2
|
Merged and made sure the temp fix isn't overwritten. Will add that to #3847 |
6 tasks
|
This also fixes offline state not being detected on the PWA properly |
hay-kot
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Fixed the bug that broke 1.10, then went and re-wrote the state management to be a lot simpler (and avoid that kind of bug in the future).
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3859
Special notes for your reviewer:
(fill-in or delete this section)
"But it worked on my machine!"
Testing
(fill-in or delete this section)
Tested from a browser with pre-existing state (i.e. has been using the offline shopping list) as well as from a browser with no state (i.e. a new incognito tab).