-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Homepage icon and text update #3922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only language file that should ever be modified directly is en-US.json
- all other translations are handled via Crowdin.
The change, from the screenshots looks good! I just can't bring myself to review it when there's 43 files changed :)
@boc-the-git oh okay, thank you for the clarification, i've slimmed it down to a more reasonable 4 file changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have general.recipes, so there's no real need to add a new "recipes" translation in. This has the added benefit of not needing people to go in and apply a new translation for it, it'll be in their language (assuming already translated) as soon as we merge this!
Otherwise, this change looks good and I'm happy to merge! Thanks :)
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
@boc-the-git updated to use general.recipes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my preferment would be for mdiSilverwareForkKnife. @boc-the-git thoughts? |
I'm fine with that too. I think not using the logo is not a bad thing here. |
icon changed to mdiSilverwareForkKnife
@boc-the-git updated to use mdiSilverwareForkKnife. |
Thanks @tyme-dev ! |
Thanks @tyme-dev for your work on this. Always nice to see new contributors submit a PR! 😊 |
Thanks @tyme-dev. The UI is way more clean and understandable now. |
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Updates text / icon on sidebar and recipe explorer page to better fit homepage context.
Changes
Before:
After:
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3815