Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Homepage icon and text update #3922

Merged
merged 11 commits into from
Jul 28, 2024

Conversation

tyme-dev
Copy link
Contributor

@tyme-dev tyme-dev commented Jul 21, 2024

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Updates text / icon on sidebar and recipe explorer page to better fit homepage context.

Changes

  • Changes Icon on sidebar for homepage and on the homepage itself from mdiMagnify to mdisilverwareFork
  • Update text on sidebar for homepage and on the homepage itself to say "Recipes" instead of "Search" or "Results"

Before:
image

After:
image

Which issue(s) this PR fixes:

(REQUIRED)
Fixes #3815

@tyme-dev tyme-dev changed the title Fix: Homepage icon and text update fix: Homepage icon and text update Jul 21, 2024
@tyme-dev tyme-dev marked this pull request as ready for review July 22, 2024 21:56
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only language file that should ever be modified directly is en-US.json - all other translations are handled via Crowdin.

The change, from the screenshots looks good! I just can't bring myself to review it when there's 43 files changed :)

@tyme-dev
Copy link
Contributor Author

@boc-the-git oh okay, thank you for the clarification, i've slimmed it down to a more reasonable 4 file changes :)

@tyme-dev tyme-dev requested a review from boc-the-git July 24, 2024 12:22
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have general.recipes, so there's no real need to add a new "recipes" translation in. This has the added benefit of not needing people to go in and apply a new translation for it, it'll be in their language (assuming already translated) as soon as we merge this!

Otherwise, this change looks good and I'm happy to merge! Thanks :)

frontend/components/Domain/Recipe/RecipeExplorerPage.vue Outdated Show resolved Hide resolved
frontend/components/Layout/DefaultLayout.vue Outdated Show resolved Hide resolved
frontend/lang/messages/en-US.json Outdated Show resolved Hide resolved
frontend/lang/messages/en-US.json Outdated Show resolved Hide resolved
tyme-dev and others added 5 commits July 25, 2024 07:28
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
@tyme-dev
Copy link
Contributor Author

@boc-the-git updated to use general.recipes

@tyme-dev tyme-dev requested a review from boc-the-git July 25, 2024 11:32
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to see a different icon used here. I think the choosen icon is a bit small in contrast to the others.

I would either suggest mdiSilverwareForkKnife or just the primary mealie icon

Bellow are screenshots for both options.

Primary ForkKnife
image image

@tyme-dev
Copy link
Contributor Author

i would like to see a different icon used here. I think the choosen icon is a bit small in contrast to the others.

I would either suggest mdiSilverwareForkKnife or just the primary mealie icon

Bellow are screenshots for both options.
Primary ForkKnife
image image

my preferment would be for mdiSilverwareForkKnife. @boc-the-git thoughts?

@boc-the-git
Copy link
Collaborator

i would like to see a different icon used here. I think the choosen icon is a bit small in contrast to the others.
I would either suggest mdiSilverwareForkKnife or just the primary mealie icon
Bellow are screenshots for both options.
Primary ForkKnife
image image

my preferment would be for mdiSilverwareForkKnife. @boc-the-git thoughts?

I'm fine with that too. I think not using the logo is not a bad thing here.

icon changed to mdiSilverwareForkKnife
@tyme-dev
Copy link
Contributor Author

@boc-the-git updated to use mdiSilverwareForkKnife.

@boc-the-git boc-the-git enabled auto-merge (squash) July 28, 2024 02:04
@boc-the-git
Copy link
Collaborator

Thanks @tyme-dev !

@boc-the-git boc-the-git merged commit cc324b2 into mealie-recipes:mealie-next Jul 28, 2024
11 checks passed
@tyme-dev tyme-dev deleted the bug/3815 branch July 28, 2024 04:09
@Kuchenpirat
Copy link
Collaborator

Thanks @tyme-dev for your work on this. Always nice to see new contributors submit a PR! 😊

@simgunz
Copy link

simgunz commented Aug 1, 2024

Thanks @tyme-dev. The UI is way more clean and understandable now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][UX] The name Search for the Recipes tab is misleading
4 participants