Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix import bookmarklet trailing slashes #4057

Merged

Conversation

vahtos
Copy link
Contributor

@vahtos vahtos commented Aug 20, 2024

What type of PR is this?

documentation

What this PR does / why we need it:

Fixes the case where the recipe URL has a trailing slash. Previously, that would make the keywords and edit settings be ignored, because the resulting URL was malformed.

Testing

Example url with trailing slash: https://www.allrecipes.com/recipe/8849/baked-chicken-nuggets/

Fixes the case where the recipe URL has a trailing slash. Previously, that would make the keywords and edit settings be ignored, because the resulting URL was malformed.
Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@michael-genson michael-genson enabled auto-merge (squash) August 20, 2024 14:47
@michael-genson michael-genson merged commit 34c37a2 into mealie-recipes:mealie-next Aug 20, 2024
11 checks passed
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants