Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recipe with a single 'space' as the title returns "404 page not found" #4065

Conversation

Sacharr
Copy link
Contributor

@Sacharr Sacharr commented Aug 21, 2024

What type of PR is this?

  • bug

What this PR does / why we need it:

This PR doesnt allow a user to create a recipe filled with only spaces.

Which issue(s) this PR fixes:

Fixes #3505

Testing

Navigate to the Create Recipe Manually screen, type a single or multiple spaces into the input.
The Create button will no longer enable itself unless a valid string is entered.

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@michael-genson michael-genson enabled auto-merge (squash) August 23, 2024 13:55
@michael-genson michael-genson merged commit 29f88ea into mealie-recipes:mealie-next Aug 23, 2024
11 checks passed
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
…found" (mealie-recipes#4065)

Co-authored-by: Michael Genson <71845777+michael-genson@users.noreply.github.com>
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
…found" (mealie-recipes#4065)

Co-authored-by: Michael Genson <71845777+michael-genson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipe with a single 'space' as the title returns "404 page not found" - reproduced on the demo site
3 participants