Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shopping list UI overhaul #4077

Closed
Closed
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export default defineComponent({
setup(props, context) {
const { i18n } = useContext();
const displayRecipeRefs = ref(false);
const itemLabelCols = ref<string>(props.value.checked ? "auto" : props.showLabel ? "4" : "6");
const itemLabelCols = ref<string>(props.value.checked ? "auto" : props.showLabel ? "8" : "9");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot more sense for long list items 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR for this change...
#4237


const contextMenu: actions[] = [
{
Expand Down
5 changes: 2 additions & 3 deletions frontend/components/global/BaseButtonGroup.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
<v-menu v-if="btn.children" :key="'menu-' + btn.event" active-class="pa-0" offset-y top left :style="stretch ? 'width: 100%;' : ''">
<template #activator="{ on, attrs }">
<v-btn tile :large="large" icon v-bind="attrs" v-on="on">
<v-icon>
{{ btn.icon }}
</v-icon>
<v-icon>{{ btn.icon }}</v-icon>
</v-btn>
</template>
<v-list dense>
<template v-for="(child, idx) in btn.children">
<v-list-item :key="idx" dense @click="$emit(child.event)">
<v-icon :color=child.color>{{ child.icon }}</v-icon>
<v-list-item-title>{{ child.text }}</v-list-item-title>
</v-list-item>
<v-divider v-if="child.divider" :key="`divider-${idx}`" class="my-1"></v-divider>
Expand Down
2 changes: 1 addition & 1 deletion frontend/composables/use-users/preferences.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export function useShoppingListPreferences(): Ref<UserShoppingListPreferences> {
"shopping-list-preferences",
{
viewAllLists: false,
viewByLabel: false,
viewByLabel: true,
},
{ mergeDefaults: true }
// we cast to a Ref because by default it will return an optional type ref
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/group/data/labels.vue
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export default defineComponent({
editLabel.value = item;

if (!editLabel.value.color) {
editLabel.value.color = "#E0E0E0";
editLabel.value.color = "#757575";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you changed this?

Copy link
Contributor Author

@Wetzel402 Wetzel402 Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly the new label dividers made visibility poor on one of the themes so I made it a bit darker gray to compensate. I would have to play with it to let you know for sure.

Edit: Yes, in the dark theme readability is an issue so I darkened the color...
image
image
image

}
}

Expand Down
Loading
Loading