fix: Image height in home screen mobile format #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The other places this gets used are the normal (non-condensed) view, and the meal planner edit view. Would you be able to share screenshots of the differences there? (if any) |
|
Other locations like meal planner, recipes timeline and search results have not changed because the default value (125px) has been set for the image size. Normally only the home screen uses the 'fill-height' property. |
michael-genson
approved these changes
Aug 23, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Adding recipe tags to recipe cards #3864 can make the recipe card bigger and create a blank space below the image.
This PR fixes this bug by filling the height of the card with the image.
Before:
After:
Also the button for toggling the mobile card view was fixed using another breakpoint.
Which issue(s) this PR fixes:
(REQUIRED)
N/A