docs: boolean value in docker-compose examples not deserializable in env variables #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks! I noticed it works fine in mine without quotes, but I think it's because I use list syntax instead of map syntax? Maybe it's undefined behavior? Who knows, I can barely find docs about it.
Would we be able to use double quotes? Only because we already have the port in double quotes.
hay-kot
requested changes
Sep 11, 2024
docs/docs/documentation/getting-started/installation/postgres.md
Outdated
Show resolved
Hide resolved
hay-kot
approved these changes
Sep 11, 2024
michael-genson
approved these changes
Sep 11, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
…env variables (mealie-recipes#4130) Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
…env variables (mealie-recipes#4130) Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
Choromanski
pushed a commit
to Choromanski/mealie
that referenced
this pull request
Oct 1, 2024
…env variables (mealie-recipes#4130) Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Booleans values in docker-compose environment variables are not deserializable and results in an error like this
Which issue(s) this PR fixes:
N/A