Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken Social Preview Links #4183

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Households broke the social preview links due to changes to how we access repos. This PR fixes them and adds a few tests.

Which issue(s) this PR fixes:

(REQUIRED)

N/A

tests/integration_tests/test_spa.py Fixed Show fixed Hide fixed
tests/integration_tests/test_spa.py Dismissed Show dismissed Hide dismissed
boc-the-git
boc-the-git previously approved these changes Sep 11, 2024
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this area of the code base, but LGTM!

One question.

tests/integration_tests/test_spa.py Dismissed Show dismissed Hide dismissed
@boc-the-git boc-the-git enabled auto-merge (squash) September 12, 2024 09:35
@boc-the-git boc-the-git merged commit f796258 into mealie-recipes:mealie-next Sep 12, 2024
13 checks passed
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
Choromanski pushed a commit to Choromanski/mealie that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants