feat: Add Household Filter to Meal Plan Rules #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recipes-by-household
…recipes-by-household
michael-genson
changed the title
…sehold-filter-to-mealplan-rules
boc-the-git
reviewed
Sep 23, 2024
michael-genson
commented
Sep 25, 2024
michael-genson
merged commit 4712994
into
mealie-recipes:mealie-next
11 of 12 checks passed
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Choromanski
pushed a commit
to Choromanski/mealie
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Adds a household filter to meal plan rules. Similar to tags and categories, if no household is selected, then all households are considered. I had to re-write the part of the recipes repo that does the filtering by tag/category (since we need to support household, too) and ended out just removing it and using the normal
page_allroute, since that already supports tags, categories, households, and random ordering.New rule form:
I also tweaked how meal plan rules render on the frontend to call out when there are no filters (e.g. "All Tags" when no tags are selected):
Which issue(s) this PR fixes:
(REQUIRED)
Closes #4081
Testing
Pytest coverage. I was surprised to find we didn't have any existing coverage for meal plan rules other than basic CRUD, so I added tests for other filters too (type, tag, etc.).