feat: Create Recipe From HTML or JSON #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
force-pushed
the
feat/create-recipe-from-json
branch
from
c55654f
to
53bf00d
Compare
Kuchenpirat
approved these changes
Sep 30, 2024
| @@ -52,6 +52,11 @@ export default defineComponent({ | |||
| text: i18n.tc("recipe.bulk-url-import"), | |||
| value: "bulk", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
at some point we should try to simplify that list somehow. It kepps getting longer and longer...
There was a problem hiding this comment.
Yeah I agree, we're gonna have to do something about it soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR adds the ability to create a recipe from raw HTML or JSON. We leverage the existing URL scrapers as-is, but bypass calling the target URL and instead provide the HTML/JSON directly (JSON must be in schema.org format, although if OpenAI is enabled it might figure it out regardless).
This is suggested on the create by URL page:
Which brings you here:
You can put HTML or JSON into that text field, however you may optionally use the JSON editor mode for JSON:
The main advantages of this are:
Which issue(s) this PR fixes:
(REQUIRED)
Closes #3224
Closes #2391
Special notes for your reviewer:
I changed some of the "create" route names because they're getting a bit unorganized. All recipe create routes are now under
/recipe/create/.... This is a breaking change, so I added it to the migration docs.Testing
(fill-in or delete this section)
Pytest