Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update rest call for home assistant #4341

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

PurelyNicole
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • documentation

What this PR does / why we need it:

The method shown in the guide is not the best practice. It calls the API twice when one call will do. This change calls the API once, and then parses the JSON to get the sensors required.

Testing

Used GitHub preview to ensure formatting was correct. As for content, this is how I have set up the sensors in my instance of Home Assistant.

The method shown in the guide is not the best practice. It pings the API twice when one call will do.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2024
Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michael-genson michael-genson enabled auto-merge (squash) October 10, 2024 02:20
@michael-genson michael-genson merged commit 4e4bc1b into mealie-recipes:mealie-next Oct 10, 2024
13 checks passed
@PurelyNicole PurelyNicole deleted the patch-1 branch October 10, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants