-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Shopping list UI overhaul - collapsible labels #4378
Open
Wetzel402
wants to merge
8
commits into
mealie-recipes:mealie-next
Choose a base branch
from
Wetzel402:collapsable-labels
base: mealie-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Shopping list UI overhaul - collapsible labels #4378
Wetzel402
wants to merge
8
commits into
mealie-recipes:mealie-next
from
Wetzel402:collapsable-labels
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wetzel402
force-pushed
the
collapsable-labels
branch
from
October 21, 2024 14:27
1218539
to
8ecddb0
Compare
Kuchenpirat
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thanks for your continued work on the shopping list, your previous changes made it to the highlight section in our v2 release notes, so congrats on that 🚀🥳
Here are just a few first comments. This is all i have time for today. So this is quite limited,
Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
Kuchenpirat
requested changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#4175
Testing
Tested in dev container