fix: Random Recipes not choosing from all recipes #4435
+50
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Our way of choosing a random recipe in the frontend assumes all recipes are loaded, but since we're paginating they're not.
This PR makes an extra API call to choose a random recipe using the backend, consequently choosing a recipe from the entire db (rather than one or two pages).
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #4250
Testing
(fill-in or delete this section)
Manually hit random a few times and confirmed I'm seeing more than just the first two pages of recipes. I can also see the API call. I also tested to make sure other filters are preserved (e.g. if you have a category filter, then clicking random preserves the filter in its recipe pool).