Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Recipe Edit: Shift parse button up towards Ingredients header #4957

Open
wants to merge 4 commits into
base: mealie-next
Choose a base branch
from

Conversation

CloCkWeRX
Copy link

What this PR does / why we need it:

Makes it easier to locate the "Parse" ingredients functionality after swapping a recipe over to detailed ingredients mode.

Before:
image

After:
image

Which issue(s) this PR fixes:

A small part of #4954

Testing

At the moment, this is purely frontend changes via chrome's web console + the corresponding changes in the vue structure. Warrants a manual test to make sure I didn't screw it up!

@CloCkWeRX CloCkWeRX marked this pull request as draft January 27, 2025 02:57
@CloCkWeRX CloCkWeRX marked this pull request as ready for review January 27, 2025 04:36
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR.
I feel like this can be improved further.
I would suggest putthing the button the same row as the ingredients and having the button aligned to the right (like the other buttons)

@Kuchenpirat Kuchenpirat self-assigned this Feb 3, 2025
@CloCkWeRX
Copy link
Author

CloCkWeRX commented Feb 6, 2025

I would really encourage you to play with this branch locally as right now:
image

vs right aligned/same row:
image

image

  • Conflicts with change owner controls
  • Not visually grouped with ingredients header
  • Close proximity to delete ingredients controls (no are you sure/undo available; so the consequences of a missed click = high)

While some of that can be addressed by just adding more and more whitespace/margins/etc; its basically just going to end up with the same visual spacing as it currently does; and it won't imply as strongly that "Parse" is "parse ingredients" (https://www.nngroup.com/articles/gestalt-proximity/)

@Kuchenpirat
Copy link
Collaborator

Hey, sorry it took me so long to get back to this. Vacation got in the way of it.

I am absolutely on bord with you that my initial suggestions is not the way to go. That makes everything just way to crammed.

I pulled your PR and played around a bit with it and i feel like sticking to the right is still a better option than the left which i feel crashes the layout a bit. What do you think of the implementation below?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants