Simple test enhancement #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest parameters don't have the same name.
|
Sorry for the delay in response. I'm all for this. However, this stems from the project. So if you can make the PR over there (github.com/meanjs/mean) and get it merged, I'm happy to merge this. |
|
@codydaig No problem. Not sure I follow your suggestion, though. Are you saying that I should make this change to the article module's server/route tests (https://github.com/meanjs/mean/blob/master/modules/articles/tests/server/article.server.routes.tests.js)? |
jrodenbostel
pushed a commit
to jrodenbostel/mean
that referenced
this pull request
Nov 30, 2016
Simple test enhancement proposed by @jrodenbostel. Eases troubleshooting when Article save fails during test execution. Further reference here: meanjs/generator-meanjs#257 Fixes meanjs#1658
mleanos
pushed a commit
to meanjs/mean
that referenced
this pull request
Jun 13, 2017
* feat(articles): Simple test enhancement Simple test enhancement proposed by @jrodenbostel. Eases troubleshooting when Article save fails during test execution. Further reference here: meanjs/generator-meanjs#257 Fixes #1658 * updated per @simison's request
lupinthethirdgentleman
pushed a commit
to lupinthethirdgentleman/mean-dashboard
that referenced
this pull request
Aug 5, 2021
* feat(articles): Simple test enhancement Simple test enhancement proposed by @jrodenbostel. Eases troubleshooting when Article save fails during test execution. Further reference here: meanjs/generator-meanjs#257 Fixes #1658 * updated per @simison's request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing this small change to help diagnose ignored save errors while testing CRUD module server routes, specifically testing the case that covers someone 'should not be able to delete an <%= humanizedSingularName %> if not signed in'. I'm working on a project where the request param and model property names don't match in all cases, and having this change in place helped me diagnose an issue that had taken an embarrassingly long time to fix.