Merge pull request #374 from igorauad/provider_names

Infer first and last name from github and twitter response
meanjs · Jan 25, 2015 · 2bba82e · 2bba82e
2 parents ecb1c68 + db067bb
commit 2bba82e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/config/strategies/github.js b/config/strategies/github.js
@@ -23,8 +23,15 @@ module.exports = function() {
 			providerData.refreshToken = refreshToken;
 
 			// Create the user OAuth profile
+			var displayName = profile.displayName.trim();
+			var iSpace = displayName.indexOf(' '); // index of the whitespace following the firstName
+			var firstName =  iSpace !== -1 ? displayName.substring(0, iSpace) : displayName;
+			var lastName = iSpace !== -1 ? displayName.substring(iSpace + 1) : '';
+
 			var providerUserProfile = {
-				displayName: profile.displayName,
+				firstName: firstName,
+				lastName: lastName,
+				displayName: displayName,
 				email: profile.emails[0].value,
 				username: profile.username,
 				provider: 'github',

diff --git a/config/strategies/twitter.js b/config/strategies/twitter.js
@@ -23,8 +23,15 @@ module.exports = function() {
 			providerData.tokenSecret = tokenSecret;
 
 			// Create the user OAuth profile
+			var displayName = profile.displayName.trim();
+			var iSpace = displayName.indexOf(' '); // index of the whitespace following the firstName
+			var firstName =  iSpace !== -1 ? displayName.substring(0, iSpace) : displayName;
+			var lastName = iSpace !== -1 ? displayName.substring(iSpace + 1) : '';
+
 			var providerUserProfile = {
-				displayName: profile.displayName,
+				firstName: firstName,
+				lastName: lastName,
+				displayName: displayName,
 				username: profile.username,
 				provider: 'twitter',
 				providerIdentifierField: 'id_str',