Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Commit

Permalink
Merge pull request #971 from jloveland/session-tests-return
Browse files Browse the repository at this point in the history
Add return done() to session secret configuration tests
  • Loading branch information
ilanbiala committed Oct 9, 2015
2 parents 3454cf8 + b07af94 commit 9c78c63
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions modules/core/tests/server/core.server.config.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ describe('Configuration Tests:', function () {
before(function(done) {
User.remove(function(err) {
should.not.exist(err);
done();
return done();
});
});

after(function(done) {
User.remove(function(err) {
should.not.exist(err);
done();
return done();
});
});

Expand Down Expand Up @@ -128,7 +128,7 @@ describe('Configuration Tests:', function () {
config.utils.validateSessionSecret(conf, true).should.equal(false);
// set env back to test
process.env.NODE_ENV = 'test';
done();
return done();
});

it('should accept non-default session secret when running in production', function (done) {
Expand All @@ -138,7 +138,7 @@ describe('Configuration Tests:', function () {
config.utils.validateSessionSecret(conf, true).should.equal(true);
// set env back to test
process.env.NODE_ENV = 'test';
done();
return done();
});

it('should accept default session secret when running in development', function (done) {
Expand All @@ -148,13 +148,13 @@ describe('Configuration Tests:', function () {
config.utils.validateSessionSecret(conf, true).should.equal(true);
// set env back to test
process.env.NODE_ENV = 'test';
done();
return done();
});

it('should accept default session secret when running in test', function (done) {
var conf = { sessionSecret: 'MEAN' };
config.utils.validateSessionSecret(conf, true).should.equal(true);
done();
return done();
});
});
});

0 comments on commit 9c78c63

Please sign in to comment.