Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Commit

Permalink
Fix Tests to Fit New Jasmine
Browse files Browse the repository at this point in the history
  • Loading branch information
@amoshaviv
amoshaviv committed Feb 15, 2014
1 parent 1c20b31 commit f0508e3
Show file tree
Hide file tree
Showing 2 changed files with 169 additions and 162 deletions.
1 change: 1 addition & 0 deletions .jshintrc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"trailing": true, // Prohibit trailing whitespaces.
"smarttabs": false, // Suppresses warnings about mixed tabs and spaces
"globals": { // Globals variables.
"jasmine": true,
"angular": true,
"ApplicationConfiguration": true
},
Expand Down
330 changes: 168 additions & 162 deletions public/modules/articles/tests/articles.spec.js
View file
Original file line number Diff line number Diff line change
@@ -1,166 +1,172 @@
'use strict';

(function() {
// Articles Controller Spec
describe('MEAN controllers', function() {
describe('ArticlesController', function() {
// Initialize global variables
var ArticlesController,
scope,
$httpBackend,
$routeParams,
$location;

// The $resource service augments the response object with methods for updating and deleting the resource.
// If we were to use the standard toEqual matcher, our tests would fail because the test values would not match
// the responses exactly. To solve the problem, we define a new toEqualData Jasmine matcher.
// When the toEqualData matcher compares two objects, it takes only object properties into
// account and ignores methods.
beforeEach(function() {
this.addMatchers({
toEqualData: function(expected) {
return angular.equals(this.actual, expected);
}
});
});

// Then we can start by loading the main application module
beforeEach(module('mean'));

// The injector ignores leading and trailing underscores here (i.e. _$httpBackend_).
// This allows us to inject a service but then attach it to a variable
// with the same name as the service.
beforeEach(inject(function($controller, $rootScope, _$location_, _$routeParams_, _$httpBackend_) {
// Set a new global scope
scope = $rootScope.$new();

// Point global variables to injected services
$routeParams = _$routeParams_;
$httpBackend = _$httpBackend_;
$location = _$location_;

// Initialize the Articles controller.
ArticlesController = $controller('ArticlesController', {
$scope: scope
});
}));

it('$scope.find() should create an array with at least one article object fetched from XHR', inject(function(Articles) {
// Create sample article using the Articles service
var sampleArticle = new Articles({
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Create a sample articles array that includes the new article
var sampleArticles = [sampleArticle];

// Set GET response
$httpBackend.expectGET('articles').respond(sampleArticles);

// Run controller functionality
scope.find();
$httpBackend.flush();

// Test scope value
expect(scope.articles).toEqualData(sampleArticles);
}));

it('$scope.findOne() should create an array with one article object fetched from XHR using a articleId URL parameter', inject(function(Articles) {
// Define a sample article object
var sampleArticle = new Articles({
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Set the URL parameter
$routeParams.articleId = '525a8422f6d0f87f0e407a33';

// Set GET response
$httpBackend.expectGET(/articles\/([0-9a-fA-F]{24})$/).respond(sampleArticle);

// Run controller functionality
scope.findOne();
$httpBackend.flush();

// Test scope value
expect(scope.article).toEqualData(sampleArticle);
}));

it('$scope.create() with valid form data should send a POST request with the form input values and then locate to new object URL', inject(function(Articles) {
// Create a sample article object
var sampleArticlePostData = new Articles({
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Create a sample article response
var sampleArticleResponse = new Articles({
_id: '525cf20451979dea2c000001',
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Fixture mock form input values
scope.title = 'An Article about MEAN';
scope.content = 'MEAN rocks!';

// Set POST response
$httpBackend.expectPOST('articles', sampleArticlePostData).respond(sampleArticleResponse);

// Run controller functionality
scope.create();
$httpBackend.flush();

// Test form inputs are reset
expect(scope.title).toEqual('');
expect(scope.content).toEqual('');

// Test URL redirection after the article was created
expect($location.path()).toBe('/articles/' + sampleArticleResponse._id);
}));

it('$scope.update() should update a valid article', inject(function(Articles) {
// Define a sample article put data
var sampleArticlePutData = new Articles({
_id: '525cf20451979dea2c000001',
title: 'An Article about MEAN',
content: 'MEAN Rocks!'
});

// Mock article in scope
scope.article = sampleArticlePutData;

// Set PUT response
$httpBackend.expectPUT(/articles\/([0-9a-fA-F]{24})$/).respond();

// Run controller functionality
scope.update();
$httpBackend.flush();

// Test URL location to new object
expect($location.path()).toBe('/articles/' + sampleArticlePutData._id);
}));

it('$scope.remove() should send a DELETE request with a valid articleId and remove the article from the scope', inject(function(Articles) {
// Create new article object
var sampleArticle = new Articles({
_id: '525a8422f6d0f87f0e407a33'
});

// Create new articles array and include the article
scope.articles = [sampleArticle];

// Set expected DELETE response
$httpBackend.expectDELETE(/articles\/([0-9a-fA-F]{24})$/).respond(204);

// Run controller functionality
scope.remove(sampleArticle);
$httpBackend.flush();

// Test array after successful delete
expect(scope.articles.length).toBe(0);
}));
});
});
// Articles Controller Spec
describe('MEAN controllers', function() {
describe('ArticlesController', function() {
// Initialize global variables
var ArticlesController,
scope,
$httpBackend,
$routeParams,
$location;

// The $resource service augments the response object with methods for updating and deleting the resource.
// If we were to use the standard toEqual matcher, our tests would fail because the test values would not match
// the responses exactly. To solve the problem, we define a new toEqualData Jasmine matcher.
// When the toEqualData matcher compares two objects, it takes only object properties into
// account and ignores methods.
beforeEach(function() {
jasmine.addMatchers({
toEqualData: function(util, customEqualityTesters) {
return {
compare: function(actual, expected) {
return {
pass: angular.equals(actual, expected)
};
}
};
}
});
});

// Then we can start by loading the main application module
beforeEach(module('mean'));

// The injector ignores leading and trailing underscores here (i.e. _$httpBackend_).
// This allows us to inject a service but then attach it to a variable
// with the same name as the service.
beforeEach(inject(function($controller, $rootScope, _$location_, _$routeParams_, _$httpBackend_) {
// Set a new global scope
scope = $rootScope.$new();

// Point global variables to injected services
$routeParams = _$routeParams_;
$httpBackend = _$httpBackend_;
$location = _$location_;

// Initialize the Articles controller.
ArticlesController = $controller('ArticlesController', {
$scope: scope
});
}));

it('$scope.find() should create an array with at least one article object fetched from XHR', inject(function(Articles) {
// Create sample article using the Articles service
var sampleArticle = new Articles({
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Create a sample articles array that includes the new article
var sampleArticles = [sampleArticle];

// Set GET response
$httpBackend.expectGET('articles').respond(sampleArticles);

// Run controller functionality
scope.find();
$httpBackend.flush();

// Test scope value
expect(scope.articles).toEqualData(sampleArticles);
}));

it('$scope.findOne() should create an array with one article object fetched from XHR using a articleId URL parameter', inject(function(Articles) {
// Define a sample article object
var sampleArticle = new Articles({
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Set the URL parameter
$routeParams.articleId = '525a8422f6d0f87f0e407a33';

// Set GET response
$httpBackend.expectGET(/articles\/([0-9a-fA-F]{24})$/).respond(sampleArticle);

// Run controller functionality
scope.findOne();
$httpBackend.flush();

// Test scope value
expect(scope.article).toEqualData(sampleArticle);
}));

it('$scope.create() with valid form data should send a POST request with the form input values and then locate to new object URL', inject(function(Articles) {
// Create a sample article object
var sampleArticlePostData = new Articles({
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Create a sample article response
var sampleArticleResponse = new Articles({
_id: '525cf20451979dea2c000001',
title: 'An Article about MEAN',
content: 'MEAN rocks!'
});

// Fixture mock form input values
scope.title = 'An Article about MEAN';
scope.content = 'MEAN rocks!';

// Set POST response
$httpBackend.expectPOST('articles', sampleArticlePostData).respond(sampleArticleResponse);

// Run controller functionality
scope.create();
$httpBackend.flush();

// Test form inputs are reset
expect(scope.title).toEqual('');
expect(scope.content).toEqual('');

// Test URL redirection after the article was created
expect($location.path()).toBe('/articles/' + sampleArticleResponse._id);
}));

it('$scope.update() should update a valid article', inject(function(Articles) {
// Define a sample article put data
var sampleArticlePutData = new Articles({
_id: '525cf20451979dea2c000001',
title: 'An Article about MEAN',
content: 'MEAN Rocks!'
});

// Mock article in scope
scope.article = sampleArticlePutData;

// Set PUT response
$httpBackend.expectPUT(/articles\/([0-9a-fA-F]{24})$/).respond();

// Run controller functionality
scope.update();
$httpBackend.flush();

// Test URL location to new object
expect($location.path()).toBe('/articles/' + sampleArticlePutData._id);
}));

it('$scope.remove() should send a DELETE request with a valid articleId and remove the article from the scope', inject(function(Articles) {
// Create new article object
var sampleArticle = new Articles({
_id: '525a8422f6d0f87f0e407a33'
});

// Create new articles array and include the article
scope.articles = [sampleArticle];

// Set expected DELETE response
$httpBackend.expectDELETE(/articles\/([0-9a-fA-F]{24})$/).respond(204);

// Run controller functionality
scope.remove(sampleArticle);
$httpBackend.flush();

// Test array after successful delete
expect(scope.articles.length).toBe(0);
}));
});
});
}());

0 comments on commit f0508e3

Please sign in to comment.