Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

replace 'swig' package with a proper solution #1286

Closed
lirantal opened this issue Mar 29, 2016 · 11 comments
Closed

replace 'swig' package with a proper solution #1286

lirantal opened this issue Mar 29, 2016 · 11 comments
Assignees
Milestone

Comments

@lirantal
Copy link
Member

We use the 'swig' package (https://github.com/paularmstrong/swig) for server side templates rendering but this package has been abandoned by it's maintainer and also includes a vulnerability that must be fixed yet no releases area available for it.

image

I'm open to recommendations for a proper replacement.

@simison
Copy link
Member

simison commented Mar 29, 2016

Swig's author recommends https://mozilla.github.io/nunjucks/

@lirantal
Copy link
Member Author

yeah I saw that but I know there are more (or used to be) popular projects like handlebars, ejb, etc.

@lirantal lirantal self-assigned this Mar 29, 2016
@lirantal lirantal added this to the 0.5.0 milestone Mar 29, 2016
@simison
Copy link
Member

simison commented Apr 1, 2016

Some reading:

@AttilaSATAN
Copy link

Nunjucks is a good and solid alternative

@simison
Copy link
Member

simison commented Jul 27, 2016

This article recommends Nunjucks: https://medium.com/@andy.neale/nunjucks-a-javascript-template-engine-7731d23eb8cc#.r4pk2ao30

Seems to be good for a boilerplate since it has potential for more complex stuff but it's still fairly simple and in this case quite similar to good ol' Swig.

@lirantal
Copy link
Member Author

Cool I'll take a look. Thanks @simison

@ilanbiala
Copy link
Member

ilanbiala commented Jul 28, 2016

Nunjucks looks fine to me, but I'm open to other ones as well.

@simison
Copy link
Member

simison commented Aug 23, 2016

@hyperreality wrote #1440 (comment):

It's hard to make the call. As far as features go they're both fantastic. Nunjucks is more actively maintained but Handlebars is getting about 20 times the amount of downloads according to NPM, and I've seen Handlebars used way more in the wild. If nothing else, there is probably more info about Handlebars out there and users are more likely to be comfortable using it.

This may be a Buridan's ass situation where both choices are equally as good and the worst thing is being stuck in the state of indecision and not choosing either.

@Ankur-Marwaha
Copy link

See if we can go with handlebars ( easy to learn, widely used ) and still if in the future we had to switch to some other templating engine it would not be that hard of a job. Lets get the solution ASAP.

@lirantal
Copy link
Member Author

Indeed, working on it.

lirantal added a commit to lirantal/meanjs that referenced this issue Aug 28, 2016
This commit introduces handlebars template system and completely replacing Swig and the Consolidate project to handle multiple template systems.
Fixes meanjs#1286
@lirantal
Copy link
Member Author

Hey guys,
Check out the new handlebars template system in PR #1461

cc @simison @Ankur-Marwaha @hyperreality @ilanbiala

lirantal added a commit that referenced this issue Aug 29, 2016
This commit introduces handlebars template system and completely replacing Swig and the Consolidate project to handle multiple template systems.
Fixes #1286
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants