bad request for non-existent image file

[sujeethk]

Manage social accounts settings page currently does one bad request for a non-existent file.

This needs to change on L6 of manage-social-accounts.client.view.html:
<img ng-src="/modules/users/client/img/buttons/{{vm.user.provider}}.png">
to:
<img ng-src="{{vm.user.provider === 'local' ? '' : '/modules/users/client/img/buttons/'+vm.user.provider+'.png'}}">

[mleanos]

I've seen this before. Definitely a bug.

The real issue is the DOM is trying to load this non-existent image because the container is only hidden but still loaded into the DOM.

We should change the condition on that DIV to use ng-if:

ng-if="vm.user.provider !== 'local'"

[sujeethk]

For some reason when i tried ng-if last night it wasn't working. I retried on a fresh copy of master and ng-if now and it works fine. Maybe i was doing something stupid