Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

getToggleElement on dropdown #250

Closed
ajonesgh opened this issue Nov 4, 2014 · 10 comments
Closed

getToggleElement on dropdown #250

ajonesgh opened this issue Nov 4, 2014 · 10 comments

Comments

@ajonesgh
Copy link

ajonesgh commented Nov 4, 2014

When clicking the link inside the drop down the console logs getToggleElement of null

@gkatsanos
Copy link

+1 I have the same problem.

@uwolfer
Copy link
Contributor

uwolfer commented Nov 4, 2014

It's an angular-ui bootstrap issue and should be fixed with the following change: angular-ui/bootstrap@ef09517

This fix should be included in their next release.

@holyxiaoxin
Copy link

I am getting this error too by following the tutorial in:
https://www.youtube.com/watch?v=XHpMH_5n2fQ

Is this code-breaking?

@uwolfer
Copy link
Contributor

uwolfer commented Nov 10, 2014

@holyxiaoxin: No it should not break your code IMHO.

@yesnault
Copy link

Angular-UI release version 0.12.0. In bower.json file, replace angular-boostrap with
"angular-bootstrap": "~0.12.0",

This issue can be closed.

@jeromegv
Copy link
Contributor

While the issue is resolved (in terms of this error showing up in the console) after upgrading to this new angular bootstrap 0.12.0 the menus in mean.js stopped working for me. Is that just me?

@simison
Copy link
Member

simison commented Nov 19, 2014

@jeromegv Menus are still working for me with MEAN 0.3.x and angular-bootstrap 0.12.0.

I've also on latest Bootstrap 3.3.1.

@jeromegv
Copy link
Contributor

See here, the breaking change is listed:
https://github.com/angular-ui/bootstrap/blob/eec68d81f4f72363d37493c495b892347bdb9e1b/CHANGELOG.md

Needs to be fixed in that file:
https://github.com/meanjs/mean/blob/master/public/modules/core/views/header.client.view.html

That fixed it for me.

Surprised it's actually working for you since it's listed as breaking change. Did you re-run bower update and cleared your cache?

@jeromegv
Copy link
Contributor

submitted a pull request: #269

@gkatsanos
Copy link

Same problem here. Thanks for the PR.

amoshaviv added a commit that referenced this issue Nov 26, 2014
fix getToggleElement on dropdown by updating to angular-bootstrap 0.12.0 #250
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants