Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

[WIP] [feat] Mongos new Auth Method #1012

Closed
wants to merge 1 commit into from

Conversation

codydaig
Copy link
Member

@mleanos @ilanbiala This is what broke from 4.1.11 to 4.1.12. They want the auth method to be specified and the user and pass fields only work if you actually have a user and pass.

@codydaig codydaig changed the title [feat] Mongos new Auth Method [WIP] [feat] Mongos new Auth Method Oct 20, 2015
@codydaig
Copy link
Member Author

@ilanbiala Stand-bye. There's still some hashing to do on this PR. @mleanos Are discussing it.

@ilanbiala
Copy link
Member

@codydaig @mleanos any progress?

@codydaig
Copy link
Member Author

@ilanbiala I'm still investigating the best method for moving forward. Regardless, I want to hold this off until 0.5 since it will most likely implement a breaking change.

In the meantime, mongoose released another patch that doesn't break this anymore so we could go back to ~ in package.json and it should work but I have yet to test and confirm this.

@ilanbiala
Copy link
Member

@codydaig Definitely would rather use ~, so let's set up a PR with that and see if Travis passes?

@mleanos
Copy link
Member

mleanos commented Oct 27, 2015

Just to follow up here, even though I already stated this in #1020

I've been testing Mongoose 4.2.3, and have confirmed that this issue has been resolved in that release. Our current implementation works just as it did before their breaking change was released.

IMO, this isn't really relevant anymore. We may need to pay attention to the upcoming Mongoose 5.0 release, and make sure we stay on top of any changes there. I have seen some discussion on them introducing some ES6 features.

@codydaig codydaig closed this Oct 28, 2015
@codydaig codydaig deleted the debug/mongoose branch October 28, 2015 05:08
@lirantal lirantal added this to the 0.4.2 milestone Oct 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants