-
Notifications
You must be signed in to change notification settings - Fork 2k
Updating package.json file for 0.4.2 release #1049
Updating package.json file for 0.4.2 release #1049
Conversation
@codydaig any other updates we need? |
@lirantal Don't forget to update the bower.json. I would like to vote to make 0.4.x a branch after the release but before we start merging 0.5 stuff in. I think there's a lot of people that picked up 0.4 and if there's any bugs, it gives us the opportunity to fix those bugs and release patches. The generator does need to be updated, however, it's on hold until @ilanbiala hashes out a refactor for the built in |
@codydaig what is there to update in bower.js? |
@lirantal We must have removed it, but I swore there was a version in the bower.json as well. Glad it's gone now! :) and I put the exact command that needs to get ran in the CONTRIBUTING.md document. |
@codydaig I did run it as follows |
19f2ccd
to
8a2a07e
Compare
@lirantal it looks for all the commits between 2 tags, so you would have to tag 0.4.2 first and then rerun this and you should see it work. |
@lirantal I will run the changelog today and make a PR to your branch for you. If there's something that I documented wrong, I will also correct that. |
@lirantal @ilanbiala I made a PR to @lirantal's branch with the updated changelog. |
Hey guys, I'll get back to this really quick! |
98e444b
to
b7180c8
Compare
weird, no idea why it's having conflicts on this branch while I can merge it with my master branch. |
had to merge from master to resolve conflicts. |
## 0.4.2 (2015-11-11) | ||
|
||
|
||
* bug(readme): Remove Broken Live Demo Link ([9bfb312](https://github.com/meanjs/mean/commit/9bfb312)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come these aren't being parsed out into a subheading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
donnu, @codydaig ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lirantal clarified, it's fine for this.
@lirantal that's fine, just make sure to rebase and squash. I'm curious about why the changelog didn't come out with a subheading for bugs though. Ideas? |
@ilanbiala It did, but I removed them since there was only one or two things that fell under bugs. It only works with the new style and since the new style wasn't implemented until the very end most commits don't fall under a heading. |
Oh okay. |
8a1f9be
to
b7180c8
Compare
b7180c8
to
bcdb663
Compare
@ilanbiala for whatever reason when I'm rebasing without a merge commit it is conflicting with master branch and we're unable to merge through Github. So I'll re-base again with a merge commit and merge for the 0.4.2 release. |
|
||
For those who will be generating releases: | ||
* Don't forget to update the changelog! | ||
* `conventional-changelog -r 1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have the proper CLI command that prepends it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably where the merge conflict is.
…042-release Conflicts: CHANGELOG.md Conflicts: CHANGELOG.md
I'll go ahead and merge as is with the merge-commit. |
LGTM |
Updating package.json file for 0.4.2 release
Preparing for 0.4.2 release, updating relevant files.